This repository was archived by the owner on Jan 10, 2023. It is now read-only.
[#162] Nullables are respected #163
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "branch-alias": { | ||
| "dev-master": "4.0-dev" | ||
| } | ||
| }, |
Owner
There was a problem hiding this comment.
This project does not use PHPUnit installed via Composer.
Owner
|
I think the solution is "too hacky". |
Author
|
@sebastianbergmann So we have two options in my opinion:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is that
token_get_allwill interpret nullables as token?plus the type token. We currently strip all tokens which are no arrays. I have added a check which will change all?into full tokens. My problem with this hack is, that we now interpret ternary operators and nullable as the same token.This PR resolves #162 with a little hack.