This repository was archived by the owner on Jan 10, 2023. It is now read-only.
Added composer.json with corresponding dependencies. #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Requires "minimum-stability": "dev"
|
+1 |
|
Can this be merged? |
|
@sebastianbergmann ping? |
Owner
|
If I have learned anything from merging Composer support to PHPUnit then it is this: do not merge pull requests that you have not tested yourself. I do not use Composer myself. So testing a pull request that adds support for Composer to one of my tools is something that requires time. Time that I do not have right now. |
Merged
Contributor
|
This PR is superseded by #58 @sebastianbergmann added steps to reproduce so that you don't have to worry about that |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I have added a composer.json with the dependencies that were described in the PEAR folder.
I have added the dependencies with the versions defined in the very same folder, but added "is greater or equal to".
Related: #52
Kind regards
Thomas