Skip to content

Add JsonWriterOptions to TemplateOptions and TemplateContext #846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebastienros merged 8 commits into from
Nov 2, 2025
Merged

Add JsonWriterOptions to TemplateOptions and TemplateContext #846

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
17ec23f
Initial plan
Copilot Nov 1, 2025
3d706c5
Add JsonWriterOptions to TemplateOptions and TemplateContext, update …
Copilot Nov 1, 2025
c01e161
Fix JsonWriterOptions copy to avoid mutating context options
Copilot Nov 1, 2025
86a03fa
Fix code style - use short type names for JsonWriterOptions
Copilot Nov 1, 2025
a9eb47a
Remove argument support from json filter, use context options directly
Copilot Nov 1, 2025
908ea18
Fix default value
sebastienros Nov 1, 2025
4a06a90
Fix syntax error
sebastienros Nov 1, 2025
27b8a11
Add doc
sebastienros Nov 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix JsonWriterOptions copy to avoid mutating context options 
Co-authored-by: sebastienros <[email protected]>
  • Loading branch information
@sebastienros
Copilot and sebastienros committed Nov 1, 2025
commit c01e1616d7f3664aa64d57093315f57a1fbd0733
15 changes: 10 additions & 5 deletions Fluid/Filters/MiscFilters.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -794,11 +794,16 @@ public static async ValueTask<FluidValue> Json(FluidValue input, FilterArguments
using var ms = new MemoryStream();

// Start with context.JsonWriterOptions, but allow argument to override Indented
var writerOptions = context.JsonWriterOptions;
if (!arguments.At(0).IsNil())
{
writerOptions.Indented = arguments.At(0).ToBooleanValue();
}
// Create a new instance to avoid modifying the context's options
var writerOptions = new JsonWriterOptions
{
Encoder = context.JsonWriterOptions.Encoder,
Indented = arguments.At(0).IsNil()
? context.JsonWriterOptions.Indented
: arguments.At(0).ToBooleanValue(),
MaxDepth = context.JsonWriterOptions.MaxDepth,
SkipValidation = context.JsonWriterOptions.SkipValidation
};

await using (var writer = new Utf8JsonWriter(ms, writerOptions))
{
Expand Down