Skip to content

Linux - check if auxdata is available #2460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 15, 2020
Merged

Linux - check if auxdata is available #2460

merged 2 commits into from
Feb 15, 2020

Conversation

guedou
Copy link
Member

@guedou guedou commented Feb 5, 2020 •
edited
Loading

This PR fixes #2447 and makes Scapy works on Linux kernel < 2.6.21 with Python3.

There are two issues:

  1. no auxdata support before Linux 2.6.21
  2. Python3 recvmsg() returns data when auxdata are not supported

@guedou guedou force-pushed the auxdata_old_kernel branch from 9e60fca to 578b730 Compare February 5, 2020 09:00
@guedou guedou mentioned this pull request Feb 5, 2020
Closed
@codecov
Copy link

codecov bot commented Feb 5, 2020 •
edited
Loading

Codecov Report

Merging #2460 into master will increase coverage by 0.75%.
The diff coverage is 4.34%.

@@            Coverage Diff             @@
##           master    #2460      +/-   ##
==========================================
+ Coverage    86.7%   87.46%   +0.75%     
==========================================
  Files         243      242       -1     
  Lines       50802    49949     -853     
==========================================
- Hits        44047    43686     -361     
+ Misses       6755     6263     -492
Impacted Files Coverage Δ
scapy/arch/linux.py 74.75% <0%> (+20.61%) ⬆️
scapy/supersocket.py 67.09% <6.25%> (+15.77%) ⬆️
scapy/contrib/cansocket.py 58.33% <0%> (-12.51%) ⬇️
scapy/contrib/scada/iec104/__init__.py 92.79% <0%> (-7.21%) ⬇️
scapy/autorun.py 72.85% <0%> (-5.66%) ⬇️
scapy/layers/tls/automaton_srv.py 73.18% <0%> (-4.72%) ⬇️
scapy/layers/tls/automaton_cli.py 79.62% <0%> (-4.02%) ⬇️
scapy/contrib/isotp.py 78.69% <0%> (-3.88%) ⬇️
scapy/layers/tftp.py 88.27% <0%> (-1.39%) ⬇️
scapy/asn1/ber.py 82.81% <0%> (-0.88%) ⬇️
... and 73 more

@guedou guedou force-pushed the auxdata_old_kernel branch 2 times, most recently from 84fec13 to af2d855 Compare February 5, 2020 21:16
@guedou guedou force-pushed the auxdata_old_kernel branch from af2d855 to 6094ac0 Compare February 6, 2020 08:08
p-l-
p-l- previously approved these changes Feb 7, 2020
View reviewed changes
gpotter2
gpotter2 reviewed Feb 7, 2020
View reviewed changes
Copy link
Member

@gpotter2 gpotter2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this

@guedou guedou force-pushed the auxdata_old_kernel branch from 381043b to e0675c5 Compare February 10, 2020 15:50
gpotter2
gpotter2 reviewed Feb 11, 2020
View reviewed changes
@guedou guedou force-pushed the auxdata_old_kernel branch from e0675c5 to 769b74d Compare February 11, 2020 09:58
@guedou guedou merged commit 6768e46 into secdev:master Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpotter2 gpotter2 gpotter2 approved these changes

@p-l- p-l- p-l- left review comments

Assignees
No one assigned
Labels
platform-specific
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

srp is missing response (Centos 5.11)
3 participants
@guedou @p-l- @gpotter2