Extension supports Varnish 5+ #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helper/Data.php
Outdated
| $applicationFactory->save(); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Need to add comment block that defines what the function does and what parameters it takes. Follow guide from other public functions.
Controller/Adminhtml/Report/Save.php
Outdated
| $proxy_image = $this->helper->getProxyImage($account_id, $application_id); | ||
|
|
||
| /** Extract the generated VCL code appropriate for their version*/ | ||
| if (strpos($proxy_image, "4" !== false)){ |
There was a problem hiding this comment.
strpos would capture 5.4.2 or something similar?
There was a problem hiding this comment.
Since varnish 4.* needs one vcl file and all the other currently released versions(5.* and 6.*) need the other, I'm stripping off all digits but the major release. Varnish 5.4.2 is hitting this if-block as "varnish:5". Feel free to suggest if you see a better way.
jstangroome
approved these changes
May 22, 2018
| $application_id = $this->state->getApplicationId(); | ||
| /** @var string $environment_name */ | ||
| $environment_name = $this->state->getEnvironmentName(); | ||
| /** @var string $proxy_image*/ |
There was a problem hiding this comment.
This code block apparently duplicated here and in UpdateVclCommand.php seems like an opportunity to refactor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds logic to deliver the appropriate magento vcl based upon the varnish image of the account making the request. Tested with Varnish 4, 5, and 6 instances alongside other proxies.