Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(G602): report constant index equal to the length asserted by an equality guard #1746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
fix(G602): report constant index equal to the length asserted by an equality guard #1746
Changes from 1 commit
2f0889464aec5b65690d9File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
…quality guard Under an "if len(s) == N" guard the *ssa.IndexAddr arm of the bounded case suppressed the issue when the constant index equalled N. Valid indices of a length-N slice are 0..N-1, so index == N is the one value that is always out of range, and G602 silently dropped it. Use isSliceIndexInsideBounds, as the sibling upperBounded arm already does, and recover the asserted length when the compared expression carries a constant offset ("len(s)-1 == 1" asserts a length of 2). Fixes part of #1727Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing