Skip to content
This repository was archived by the owner on Dec 12, 2019. It is now read-only.

Conversation

Peripheral1994
Copy link
Contributor

CC @ladanazita @hankim813

This rectifies the issue where Nanigans was receiving parameters incorrectly due to QS calling encodeURIComponent on them. We now use our own function to encode.

This relies on a report from Ladan, as I've been unable to find supporting documentation myself, so having her review would be appreciated. :)

Old behavior example: &sku%5B0%5D
New and desired behavior: &sku[0]

@codecov-io
Copy link

codecov-io commented Mar 20, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@1165593). Click here to learn what that means.
The diff coverage is 50%.

@@            Coverage Diff            @@
##             master      #13   +/-   ##
=========================================
  Coverage          ?   88.75%           
=========================================
  Files             ?        1           
  Lines             ?       80           
  Branches          ?        0           
=========================================
  Hits              ?       71           
  Misses            ?        9           
  Partials          ?        0
Impacted Files Coverage Δ
lib/index.js 88.75% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1165593...5c91f75. Read the comment docs.

@SegmentDestinationsBot
Copy link
Contributor

Hi @Peripheral1994, as part of the monorepo migration, this issue has been moved to new issue. Our engineers have been notified and will prioritize and work on it ASAP. Thank you!

For more information, see README.md.

@SegmentDestinationsBot SegmentDestinationsBot added the migrated The issue has been migrated label Dec 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
migrated The issue has been migrated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants