This repository was archived by the owner on Dec 12, 2019. It is now read-only.
Fix params from improper encoding #13
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @ladanazita @hankim813
This rectifies the issue where Nanigans was receiving parameters incorrectly due to QS calling encodeURIComponent on them. We now use our own function to encode.
This relies on a report from Ladan, as I've been unable to find supporting documentation myself, so having her review would be appreciated. :)
Old behavior example: &sku%5B0%5D
New and desired behavior: &sku[0]