Skip to content

fix: frozen string literal issue for ruby 3.4.0 #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: frozen string literal issue for ruby 3.4.0 #137

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8ae5d6
Fix frozen string literal issue
chaadow Nov 17, 2024
7689f47
Add empty line for code readability
manisha1997 Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix frozen string literal issue 
To prepare for ruby 3.4.0 and making strings frozen by default, we add `+` operator to make the string mutable
  • Loading branch information
@chaadow
chaadow committed Apr 14, 2025
commit a8ae5d6e86fbdef1403e2e6d0b915a2f25d5b831
2 changes: 1 addition & 1 deletion lib/ruby_http_client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ def build_args(args)
# - The final url string
#
def build_url(query_params: nil)
url = [add_version(''), *@url_path].join('/')
url = [add_version(+''), *@url_path].join('/')
url = build_query_params(url, query_params) if query_params
URI.parse("#{@host}#{url}")
end
Expand Down