[FIX] libc++: performance tests#3211
Merged
eseiler merged 2 commits intoseqan:masterfrom Nov 16, 2023
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
seqan-actions
added
lint
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3211 +/- ##
=======================================
Coverage 98.17% 98.17%
=======================================
Files 269 269
Lines 11852 11852
=======================================
Hits 11636 11636
Misses 216 216 ☔ View full report in Codecov by Sentry. |
eseiler
force-pushed
the
infra/performance
branch
from
81557c9 to
26c0845
Compare
seqan-actions
added
lint
eseiler
force-pushed
the
infra/performance
branch
from
26c0845 to
68807c7
Compare
seqan-actions
added
lint
smehringer
reviewed
Nov 15, 2023
Comment on lines
101
to
104
| | std::views::transform( | ||
| [seed](uint64_t const i) | ||
| [](uint64_t const i) | ||
| { | ||
| return i ^ seed; | ||
| }); |
Member
Author
There was a problem hiding this comment.
It's implicitly captured because it's const.
| { | ||
| index_simd_t simd_index{}; | ||
| for (size_t index = 0; index < end_index; ++index, ++simd_index) | ||
| for (size_t index = 0; index < end_index; ++index, simd_index += 1) |
Member
There was a problem hiding this comment.
++ did not work? seems so basic
Member
Author
There was a problem hiding this comment.
Libc++ says it implements ++ for Simd types, but it doesn't work :D
smehringer
approved these changes
Nov 15, 2023
eseiler
force-pushed
the
infra/performance
branch
from
68807c7 to
e0a14f1
Compare
seqan-actions
added
lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.