Skip to content

Size based EventId LogEventProperty cache #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nblumhardt merged 10 commits into from
Nov 15, 2024
Merged

Size based EventId LogEventProperty cache #260

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d0dbbb1
Extend LogEventBenchmark with ILogger.Log that includes EventId.
andrii-babanin-sym Oct 31, 2024
0e5fe4c
Implement EventId to LogEventProperty cache.
andrii-babanin-sym Oct 31, 2024
4eb8b3c
Use EventIdPropertyCache in SerilogLogger; Create EventIdPropertyCach…
andrii-babanin-sym Oct 31, 2024
919b919
Compare both Id and Name for equity.
andrii-babanin-sym Oct 31, 2024
b68c884
Remove comment.
andrii-babanin-sym Oct 31, 2024
3731bcb
Define EventKey as readonly record struct.
andrii-babanin-sym Nov 1, 2024
59165d5
Change copyright text.
andrii-babanin-sym Nov 1, 2024
cb77647
Shared static EventIdPropertyCache cache; Use ConcurrentDictionary as…
andrii-babanin-sym Nov 1, 2024
29b94f3
Revert sample code changes.
andrii-babanin-sym Nov 1, 2024
2bc0ea5
Make EventIdPropertyCache non-static; Create unit tests.
andrii-babanin-sym Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Extend LogEventBenchmark with ILogger.Log that includes EventId.
  • Loading branch information
@andrii-babanin-sym
andrii-babanin-sym committed Oct 31, 2024
commit d0dbbb1f45c3bd2bc2ea46d9c3fbadadb39cf951
12 changes: 12 additions & 0 deletions test/Serilog.Extensions.Logging.Benchmarks/LogEventBenchmark.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ private class Person

readonly IMelLogger _melLogger;
readonly Person _bob, _alice;
readonly EventId _eventId = new EventId(1, "Test");

public LogEventBenchmark()
{
Expand Down Expand Up @@ -61,5 +62,16 @@ public void LogInformationScoped()
using (var scope = _melLogger.BeginScope("Hi {@User} from {$Me}", _bob, _alice))
_melLogger.LogInformation("Hi");
}

[Benchmark]
public void LogInformation_WithEventId()
{
this._melLogger.Log(
LogLevel.Information,
_eventId,
"Hi {@User} from {$Me}",
_bob,
_alice);
}
}
}