Skip to content

Fix issue with force-reopen after 30 minutes #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nblumhardt merged 4 commits into from
Mar 7, 2025
Merged

Fix issue with force-reopen after 30 minutes #337

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7c44444
Fix issue with force-reopen after 30 minutes
Falco20019 Feb 20, 2025
a3cd930
Fix issue with FileSink not closing the stream on hook errors
Falco20019 Feb 20, 2025
836854e
Ensure SelfLog will not tear into other tests
Falco20019 Feb 20, 2025
455a10f
Comment out SelfLog for now as requested
Falco20019 Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Ensure SelfLog will not tear into other tests
  • Loading branch information
@Falco20019
Falco20019 committed Feb 20, 2025
commit 836854e609bcd7c038296fa1dc70aeb167ed8672
7 changes: 6 additions & 1 deletion test/Serilog.Sinks.File.Tests/RollingFileSinkTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

namespace Serilog.Sinks.File.Tests;

public class RollingFileSinkTests
public class RollingFileSinkTests : IDisposable
{
private readonly ITestOutputHelper _testOutputHelper;

Expand All @@ -18,6 +18,11 @@ public RollingFileSinkTests(ITestOutputHelper testOutputHelper)
_testOutputHelper = testOutputHelper;
}

public void Dispose()
{
SelfLog.Disable();
}

[Fact]
public void LogEventsAreEmittedToTheFileNamedAccordingToTheEventTimestamp()
{
Expand Down