[#222] Prevent progress bar rendering from abort #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Martoon-00
approved these changes
Jan 23, 2023
Member
Martoon-00
left a comment
Martoon-00
left a comment
There was a problem hiding this comment.
That's what I meant, thank you 👍
However let's also wait for @dcastro's reply on this message, he is now back from vacation and I asked him to take a look when he has time.
aeqz
force-pushed
the
aeqz/#222-prevent-progress-bar-rendering-abort
branch
2 times, most recently
from
fc991f9 to
a7a85f7
Compare
Problem: It seems that the current progress bar rendering action is not completely protected against exceptions. Solution: As it is an action that runs for a short amount of time and we really want it to not be interrputed, we can wrap it with uninterruptibleMask. The resulting rendering loop also gets simpler with this change.
aeqz
force-pushed
the
aeqz/#222-prevent-progress-bar-rendering-abort
branch
from
a7a85f7 to
202706e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem: It seems that the current progress bar rendering action is not completely protected against exceptions.
Solution: As it is an action that runs for a short amount of time and we really want it to not be interrputed, we can wrap it with
uninterruptibleMask. The resulting rendering loop also gets simpler with this change.Related issue(s)
Fixes #222
Related changes (conditional)
Tests
silently reappearing again.
Documentation
Public contracts
of Public Contracts policy.
and
Stylistic guide (mandatory)