-
Notifications
You must be signed in to change notification settings - Fork 417
add hook *before:step-functions-offline:start* #313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
c9dbb6c
add hook *before:step-functions-offline:start*
vkkis93 f78d5e9
use compile instead of wpwatch
vkkis93 a1631bc
Update index.js
vkkis93 bab15c8
Create prepareStepOfflineInvoke.js
vkkis93 ba7ec41
fix eslint
vkkis93 b4e98d2
Update index.js
vkkis93 bd46cd9
Update prepareStepOfflineInvoke.js
vkkis93 20f84a1
Added unit tests for prepareStepOfflineInvoke
245ced2
Added step-offline to separate supported plugins section
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| 'use strict'; | ||
|
|
||
| const _ = require('lodash'); | ||
| const path = require('path'); | ||
|
|
||
| /** | ||
| * Special settings for use with serverless-offline. | ||
| */ | ||
|
|
||
| module.exports = { | ||
| prepareStepOfflineInvoke() { | ||
| _.set(this.serverless, 'service.package.individually', false); | ||
|
|
||
| return this.serverless.pluginManager.spawn('webpack:validate') | ||
| .then(() => { | ||
| if (!this.options.location && !_.get(this.serverless, 'service.custom.stepFunctionsOffline.location')) { | ||
| _.set(this.serverless, 'service.custom.stepFunctionsOffline.location', | ||
| path.relative(this.serverless.config.servicePath, path.join(this.webpackOutputPath, 'service')) | ||
| ); | ||
| } | ||
| return null; | ||
| }); | ||
| } | ||
| }; | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be
step-functions-offlineinstead ofserverless-offline.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed
Should be serverless-step-functions-offline (it's name of plugin)