Skip to content

Do not swallow errors in case npm ls fails without an empty stdout and use spawn for child processes #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 25, 2018
Merged

Do not swallow errors in case npm ls fails without an empty stdout and use spawn for child processes #373

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b379de9
Utils unit tests
Apr 25, 2018
3caa2b6
Fixed typo
Apr 25, 2018
4d5fa6a
Removed unnecessary configuration check
Apr 25, 2018
4ee2dfe
OOS: Added missing prepare offline unit tests
Apr 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed unnecessary configuration check
  • Loading branch information
Frank Schmid committed Apr 25, 2018
commit 4d5fa6ac69644a2263859525655287ab174e088b
3 changes: 0 additions & 3 deletions lib/Configuration.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,6 @@ class Configuration {
this._config.includeModules = custom.webpackIncludeModules;
this._hasLegacyConfig = true;
}
if (custom.packExternalModulesMaxBuffer) {
this._hasLegacyConfig = true;
}
if (_.isString(custom.webpack)) {
this._config.webpackConfig = custom.webpack;
this._hasLegacyConfig = true;
Expand Down