Fix aws-profile cli option to override env & config#3980
Merged
Conversation
This was referenced Jul 24, 2017
Contributor
|
@mpuittinen this looks great. Wanna merge it in, but seems like there's something wrong with Github/Travis integration. The build is passing, but Github is reporting an error, not sure why. Maybe it needs a refresh of some kind. Do you mind maybe updating your branch to refresh the build? maybe a pull from our master would suffice? |
pmuens
approved these changes
Aug 23, 2017
pmuens
left a comment
pmuens
left a comment
Contributor
There was a problem hiding this comment.
Tested this as well. Works on my machine...
Looks like the build problem was resolved so we can merge this 🎉 --> Merging... 
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What did you implement:
Closes #3979
How did you implement it:
Split handling of serverless.provider.profile (from serverless.yml) and cli option aws-profile into two different cases in awsProvider.js since they have different prioritites.
Set the AWS_PROFILE env in the aws-profile option test to verify that the profile set overrides the env.
How can we verify it:
AWS_PROFILE=foobar serverless deploy --aws-profile myprofile
This now deploys to myprofile, previously it tried to deploy to foobar.
Todos:
Is this ready for review?: YES
Is it a breaking change?: NO