Skip to content

Don't send sentry_timestamp in the header. #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 14, 2019
Merged

Don't send sentry_timestamp in the header. #28

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06a1e9a
Don't send sentry_timestamp in the header.
15joeybloom Dec 13, 2019
4bbab48
Send sentry_timestamp in the header as a UNIX timestamp
15joeybloom Dec 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Don't send sentry_timestamp in the header.
  • Loading branch information
@15joeybloom
15joeybloom committed Dec 13, 2019
commit 06a1e9a54a95d0c7289c58048b1384e666872c90
10 changes: 4 additions & 6 deletions src/raven_clj/core.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,19 +23,18 @@
uri project-id))

(defn make-sentry-header
[ts key secret]
[key secret]
(->> ["Sentry sentry_version=2.0"
(format "sentry_client=%s" sentry-client)
(format "sentry_timestamp=%s" ts)
(format "sentry_key=%s" key)
(when secret
(format "sentry_secret=%s" secret))]
(remove nil?)
(string/join ", ")))

(defn send-packet [{:keys [ts uri project-id key secret] :as packet-info}]
(defn send-packet [{:keys [uri project-id key secret] :as packet-info}]
(let [url (make-sentry-url uri project-id)
header (make-sentry-header ts key secret)
header (make-sentry-header key secret)
body (dissoc packet-info :ts :uri :project-id :key :secret)]
(http/post url
{:throw-exceptions false
Expand Down Expand Up @@ -67,8 +66,7 @@
(merge (parse-dsn dsn)
{:level "error"
:platform "clojure"
:server_name (.getHostName (InetAddress/getLocalHost))
:ts (str (Timestamp. (.getTime (Date.))))}
:server_name (.getHostName (InetAddress/getLocalHost))}
event-info
{:event_id (generate-uuid)})))

Expand Down
30 changes: 24 additions & 6 deletions test/raven_clj/core_test.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,23 +20,34 @@

(deftest test-make-sentry-header
(testing "sentry header"
(let [ts (str (Timestamp. (.getTime (Date.))))
key "b70a31b3510c4cf793964a185cfe1fd0"
(let [key "b70a31b3510c4cf793964a185cfe1fd0"
secret "b7d80b520139450f903720eb7991bf3d"
client-version (version)
hdr (make-sentry-header ts key secret)]
hdr (make-sentry-header key secret)]

(is (.contains hdr "sentry_version=2.0")
"includes sentry version")
(is (.contains hdr (str "sentry_client=raven-clj/" client-version))
"includes client version")
(is (.contains hdr (format "sentry_timestamp=%s" ts))
"includes timestamp")
(is (.contains hdr (str "sentry_key=" key))
"includes key")
(is (.contains hdr (str "sentry_secret=" secret))
"includes secret")
(is (= hdr (format "Sentry sentry_version=2.0, sentry_client=raven-clj/%s, sentry_timestamp=%s, sentry_key=%s, sentry_secret=%s" client-version ts key secret))))))
(is (= hdr (format "Sentry sentry_version=2.0, sentry_client=raven-clj/%s, sentry_key=%s, sentry_secret=%s" client-version key secret)))))

(testing "sentry header without secret"
(let [key "b70a31b3510c4cf793964a185cfe1fd0"
secret nil
client-version (version)
hdr (make-sentry-header key secret)]

(is (.contains hdr "sentry_version=2.0")
"includes sentry version")
(is (.contains hdr (str "sentry_client=raven-clj/" client-version))
"includes client version")
(is (.contains hdr (str "sentry_key=" key))
"includes key")
(is (= hdr (format "Sentry sentry_version=2.0, sentry_client=raven-clj/%s, sentry_key=%s" client-version key secret))))))

(deftest test-send-packet
(testing "send-packet"
Expand All @@ -62,6 +73,13 @@
:uri "https://example.com"
:project-id 1})))

(testing "dsn parsing without secret"
(is (= (parse-dsn "https://[email protected]/1")
{:key "b70a31b3510c4cf793964a185cfe1fd0"
:secret nil
:uri "https://example.com"
:project-id 1})))

(testing "dsn parsing with path"
(is (= (parse-dsn "https://b70a31b3510c4cf793964a185cfe1fd0:[email protected]/sentry/1")
{:key "b70a31b3510c4cf793964a185cfe1fd0"
Expand Down