-
Notifications
You must be signed in to change notification settings - Fork 3.7k
dockerfile: add lightweight runtime stage and refactors #13861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @ishandhanani, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a comprehensive refactoring of the Dockerfile to implement a multi-stage build strategy. The core objective is to create a highly optimized and lightweight runtime image for SGLang, distinct from the development and build environment. This change enhances build performance, ensures correct CUDA architecture compatibility, and improves the overall reliability of the Docker image creation process. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces significant improvements to the Dockerfile by refactoring it into a multi-stage build with base, framework, and runtime stages. This is a great change that improves maintainability, reduces image size for production, and optimizes the build process. The introduction of a lightweight runtime stage is particularly valuable. Other notable improvements include adding retry logic for downloads, fixing a critical CUDA architecture compilation bug, and better organization of dependencies.
I have one suggestion to further optimize the runtime stage by combining apt operations to reduce layers and remove redundant commands. Overall, this is an excellent contribution.
|
PR looks good to me |
ac2e8ff to
9e7fd89
Compare
nv-tusharma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few comments I've made so feel free to check those out but overall LGTM.
a92cfc3 to
0ed8083
Compare
…into ishan/dockerfile-opt
|
Need to add some explanation for the runtime image here |
…into ishan/dockerfile-opt
08e5907 to
350cd25
Compare
|
In the new Docker image zsh
bash: zsh: command not found |
Will merge this in after next release
Multi-stage Dockerfile splits SGLang builds into base, framework, and runtime stages. Runtime cuts image size roughly in half.
Tests