fix: pie chart custom label dark mode support#10223
Open
mahmoodhamdi wants to merge 1 commit intoshadcn-ui:mainfrom
Open
fix: pie chart custom label dark mode support#10223mahmoodhamdi wants to merge 1 commit intoshadcn-ui:mainfrom
mahmoodhamdi wants to merge 1 commit intoshadcn-ui:mainfrom
Conversation
Replace fill="var(--foreground)" with className="fill-foreground" in chart-pie-label-custom to properly support dark mode, consistent with other chart label examples (chart-bar-label, chart-line-label). Closes shadcn-ui#9703
Contributor
|
@mahmoodhamdi is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixed the custom label in
chart-pie-label-customnot being visible in dark mode.Why
The
<text>element usedfill="var(--foreground)"as an SVG attribute, which doesn't respond to dark mode theme changes. In dark mode, the label text remains dark-colored against the dark background, making it invisible.How
Replaced
fill="var(--foreground)"withclassName="fill-foreground"(Tailwind utility class), which is the established pattern used by other chart label examples:chart-bar-label.tsxchart-bar-label-custom.tsxchart-line-label.tsxchart-line-label-custom.tsxTesting
Closes #9703