fix: Carousel keyboard navigation for vertical orientation#10233
Open
mahdirajaee wants to merge 1 commit intoshadcn-ui:mainfrom
Open
fix: Carousel keyboard navigation for vertical orientation#10233mahdirajaee wants to merge 1 commit intoshadcn-ui:mainfrom
mahdirajaee wants to merge 1 commit intoshadcn-ui:mainfrom
Conversation
Contributor
|
@mahdirajaee is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes #10219
The Carousel component's
handleKeyDowncallback only handlesArrowLeftandArrowRightkeys, regardless of the carousel's orientation. When orientation is set to"vertical", pressingArrowUp/ArrowDowndoes nothing, andArrowLeft/ArrowRightstill triggers prev/next navigation, which is incorrect for a vertical layout.Fix
Updated
handleKeyDownto check theorientationprop and select the appropriate key bindings:ArrowLeftfor previous,ArrowRightfor nextArrowUpfor previous,ArrowDownfor nextAdded
orientationto theuseCallbackdependency array so the handler updates when orientation changes.Files changed
apps/v4/registry/bases/base/ui/carousel.tsxapps/v4/registry/bases/radix/ui/carousel.tsxBoth the base and radix implementations have been updated with the same fix.