fix(native-select): apply computed background color to options (#10237)#10240
Open
aakarsh12x wants to merge 2 commits intoshadcn-ui:mainfrom
Open
fix(native-select): apply computed background color to options (#10237)#10240aakarsh12x wants to merge 2 commits intoshadcn-ui:mainfrom
aakarsh12x wants to merge 2 commits intoshadcn-ui:mainfrom
Conversation
Contributor
|
Someone is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10237
This PR resolves an issue where the background colors of native
<option>and<optgroup>elements inside theNativeSelectcomponent fallback (and mobile views) were not correctly applying the CSS variables and modernoklch()color utilities, specifically in dark mode on chromium-based browsers.The Problem
Native option elements are rendered outside the CSS cascade by the OS/browser chrome. Because of this:
var(--input), etc.).color-mix(in oklch...)applied via Tailwind on the parent<select>are ignored on the children elements, leaving them with the system default color (which causes bright whiteoptionbackgrounds on dark-mode pages).The Solution
Instead of relying purely on the CSS cascade for native options, we use a custom
useResolvedOptionStylehook with a React Context:<select>and reads thegetComputedStyle()of the element on mount (and safely refires on theme toggles via aMutationObserver).rgb()format.NativeSelectContext.NativeSelectOptionandNativeSelectOptGroupmerge these securely as explicit inlinestyleattributes—which are reliably respected across browsers regardless of the CSS cascade limitations.Changes Made
NativeSelect(new-york-v4): AddeduseResolvedOptionStylehook + Context Provider to forward computed color values to children as inline styles.NativeSelect(base): Replicated fix.NativeSelect(radix): Replicated fix.Testing Performed