fix(slider): add thumbLabels prop for multi-thumb accessibility#10249
Open
greencookie-afk wants to merge 1 commit intoshadcn-ui:canaryfrom
Open
fix(slider): add thumbLabels prop for multi-thumb accessibility#10249greencookie-afk wants to merge 1 commit intoshadcn-ui:canaryfrom
greencookie-afk wants to merge 1 commit intoshadcn-ui:canaryfrom
Conversation
Add optional thumbLabels array prop to Slider component to provide
distinct accessible names for each thumb in multi-thumb sliders.
Each thumb receives aria-label={thumbLabels?.[index]} enabling
screen reader users to distinguish between minimum and maximum
value controls in range sliders.
Fixes shadcn-ui#10221
Contributor
|
Someone is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add optional
thumbLabelsprop to the Slider component for accessible multi-thumb sliders.Problem
Multi-thumb sliders (e.g., price range filters) have no way to distinguish thumbs for screen readers. This violates WAI-ARIA requirements.
Solution
thumbLabels?: string[]proparia-label={thumbLabels?.[index]}Usage
Fixes #10221