Skip to content

feat(Combobox): Add generics in base-ui combobox for better type inference #10251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yogesh200002 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(Combobox): Add generics in base-ui combobox for better type inference #10251

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
927838b
feat: Add generics in base-ui combobox for better type inference
yogesh200002 Apr 1, 2026
d895979
chore: Update styles json and tsx files according to new combobox file
yogesh200002 Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore: Update styles json and tsx files according to new combobox file
  • Loading branch information
@yogesh200002
yogesh200002 committed Apr 1, 2026
commit d8959792efdb0240d744f283696aedd7ccbba7e4
2 changes: 1 addition & 1 deletion apps/v4/public/r/styles/base-luma/combobox.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion apps/v4/public/r/styles/base-lyra/combobox.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion apps/v4/public/r/styles/base-maia/combobox.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion apps/v4/public/r/styles/base-mira/combobox.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion apps/v4/public/r/styles/base-nova/combobox.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion apps/v4/public/r/styles/base-vega/combobox.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion apps/v4/public/r/styles/new-york-v4/combobox.json
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 5 additions & 1 deletion apps/v4/styles/base-luma/ui/combobox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,11 @@ import {
InputGroupInput,
} from "@/styles/base-luma/ui/input-group"

const Combobox = ComboboxPrimitive.Root
function Combobox<Value, Multiple extends boolean | undefined = false>(
props: ComboboxPrimitive.Root.Props<Value, Multiple>
) {
return <ComboboxPrimitive.Root {...props} />
}

function ComboboxValue({ ...props }: ComboboxPrimitive.Value.Props) {
return <ComboboxPrimitive.Value data-slot="combobox-value" {...props} />
Expand Down
6 changes: 5 additions & 1 deletion apps/v4/styles/base-lyra/ui/combobox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,11 @@ import {
InputGroupInput,
} from "@/styles/base-lyra/ui/input-group"

const Combobox = ComboboxPrimitive.Root
function Combobox<Value, Multiple extends boolean | undefined = false>(
props: ComboboxPrimitive.Root.Props<Value, Multiple>
) {
return <ComboboxPrimitive.Root {...props} />
}

function ComboboxValue({ ...props }: ComboboxPrimitive.Value.Props) {
return <ComboboxPrimitive.Value data-slot="combobox-value" {...props} />
Expand Down
6 changes: 5 additions & 1 deletion apps/v4/styles/base-maia/ui/combobox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,11 @@ import {
InputGroupInput,
} from "@/styles/base-maia/ui/input-group"

const Combobox = ComboboxPrimitive.Root
function Combobox<Value, Multiple extends boolean | undefined = false>(
props: ComboboxPrimitive.Root.Props<Value, Multiple>
) {
return <ComboboxPrimitive.Root {...props} />
}

function ComboboxValue({ ...props }: ComboboxPrimitive.Value.Props) {
return <ComboboxPrimitive.Value data-slot="combobox-value" {...props} />
Expand Down
6 changes: 5 additions & 1 deletion apps/v4/styles/base-mira/ui/combobox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,11 @@ import {
InputGroupInput,
} from "@/styles/base-mira/ui/input-group"

const Combobox = ComboboxPrimitive.Root
function Combobox<Value, Multiple extends boolean | undefined = false>(
props: ComboboxPrimitive.Root.Props<Value, Multiple>
) {
return <ComboboxPrimitive.Root {...props} />
}

function ComboboxValue({ ...props }: ComboboxPrimitive.Value.Props) {
return <ComboboxPrimitive.Value data-slot="combobox-value" {...props} />
Expand Down
6 changes: 5 additions & 1 deletion apps/v4/styles/base-nova/ui-rtl/combobox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,11 @@ import {
InputGroupInput,
} from "@/styles/base-nova/ui-rtl/input-group"

const Combobox = ComboboxPrimitive.Root
function Combobox<Value, Multiple extends boolean | undefined = false>(
props: ComboboxPrimitive.Root.Props<Value, Multiple>
) {
return <ComboboxPrimitive.Root {...props} />
}

function ComboboxValue({ ...props }: ComboboxPrimitive.Value.Props) {
return <ComboboxPrimitive.Value data-slot="combobox-value" {...props} />
Expand Down
6 changes: 5 additions & 1 deletion apps/v4/styles/base-nova/ui/combobox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,11 @@ import {
InputGroupInput,
} from "@/styles/base-nova/ui/input-group"

const Combobox = ComboboxPrimitive.Root
function Combobox<Value, Multiple extends boolean | undefined = false>(
props: ComboboxPrimitive.Root.Props<Value, Multiple>
) {
return <ComboboxPrimitive.Root {...props} />
}

function ComboboxValue({ ...props }: ComboboxPrimitive.Value.Props) {
return <ComboboxPrimitive.Value data-slot="combobox-value" {...props} />
Expand Down
6 changes: 5 additions & 1 deletion apps/v4/styles/base-vega/ui/combobox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,11 @@ import {
InputGroupInput,
} from "@/styles/base-vega/ui/input-group"

const Combobox = ComboboxPrimitive.Root
function Combobox<Value, Multiple extends boolean | undefined = false>(
props: ComboboxPrimitive.Root.Props<Value, Multiple>
) {
return <ComboboxPrimitive.Root {...props} />
}

function ComboboxValue({ ...props }: ComboboxPrimitive.Value.Props) {
return <ComboboxPrimitive.Value data-slot="combobox-value" {...props} />
Expand Down