Skip to content

Conversation

@zerosnacks
Copy link
Contributor

@zerosnacks zerosnacks commented May 29, 2024

Motivation

When playing around with ExEx and the repo I noticed many unused dependencies declared in Cargo.toml

Solution

  • Bumps dependencies
  • Updates to the latest version of Reth
  • Uses Reth's revm re-export in reth-revm
  • Removes unused crates
  • Small linting fixes, specifically consistent import order
  • Small fix in doctest when running: cargo test --workspace --all-targets

Currently relies on revm patch (see: paradigmxyz/reth#8447) but that should be able to be removed once new revm version has been released and updated in Reth (see: bluealloy/revm#1463)

Copy link
Contributor

@Jon-Becker Jon-Becker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you for contributing!!!

@Jon-Becker Jon-Becker changed the title Chore: update and clean up dependencies chore(deps): update and clean up dependencies May 29, 2024
@Jon-Becker Jon-Becker merged commit 41e9164 into shadow-hq:main May 29, 2024
@zerosnacks zerosnacks deleted the chore/update-and-clean-up-dependencies branch May 29, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants