fix few issues with webpack@4 #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andriijas
approved these changes
Mar 30, 2018
Contributor
andriijas
left a comment
andriijas
left a comment
There was a problem hiding this comment.
I glanced thought the file changes, looks good. I dont have time to test in real project right now unfortunately. Thanks for taking the time to fix this!
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
=======================================
+ Coverage 94.89% 100% +5.1%
=======================================
Files 2 2
Lines 98 98
=======================================
+ Hits 93 98 +5
+ Misses 5 0 -5
Continue to review full report at Codecov.
|
mastilver
force-pushed
the
finalise-webpack-4
branch
from
53f3bdd to
b5efe37
Compare
mastilver
force-pushed
the
finalise-webpack-4
branch
from
b5efe37 to
5fdbadc
Compare
There should no longer be any race condition possible, so it's pretty safe even if it could prevent the same issue not to be spotted
|
Woohoo 🎊 I have been waiting for this. Any plans to release to npm soon? |
Contributor
Author
|
YES!!! Today hopefully, I need to double check if we need anything else... :) |
Contributor
Author
|
|
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #128