Skip to content

fix(twoslash): fix onTwoslashError return value handling #1070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antfu merged 2 commits into from
Sep 1, 2025
Merged

fix(twoslash): fix onTwoslashError return value handling #1070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffd5c9e
fix(twoslash): Make it so that the code is replaced with the return v…
Karibash Sep 1, 2025
1442449
fix(vitepress-twoslash): Add missing return statement in onError func…
Karibash Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/twoslash/src/core.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ export function createTransformerFactory(
catch (error) {
const result = onTwoslashError(error, code, lang, this.options)
if (typeof result === 'string')
return code
return result
}
}
},
Expand Down
4 changes: 2 additions & 2 deletions packages/vitepress-twoslash/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export function transformerTwoslash(options: VitePressPluginTwoslashOptions = {}
explicitTrigger = true,
} = options

const onError = (error: any, code: string): void => {
const onError = (error: any, code: string): string | void => {
const isCI = typeof process !== 'undefined' && process?.env?.CI
const isDev = typeof process !== 'undefined' && process?.env?.NODE_ENV === 'development'
const shouldThrow = (options.throws || isCI || !isDev) && options.throws !== false
Expand All @@ -28,7 +28,7 @@ export function transformerTwoslash(options: VitePressPluginTwoslashOptions = {}
throw error
else
console.error(error)
removeTwoslashNotations(code)
return removeTwoslashNotations(code)
}

const twoslash = createTransformerFactory(
Expand Down
Loading