This repository was archived by the owner on Mar 18, 2018. It is now read-only.
use 24h format for releaseDirname instead of 12h #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that is what was used previously, when 'moment' was used for date formatting. 12h format causes terrible consequences: (1) every timestamp repeats twice a day, for AM and PM. Which is bad because deploy:cleanup task makes sorted list of directories, and removes oldest, which might actually happen to be the directory which was just released. (2) if your project haven't specified exact version of grunt-shipit in package.json, and multiple people are deploying from different workspaces, one might be using 0.4.2 (12h) the other 0.4.0 (24h) and then the cleanup of your current dir will hit you for sure.
gregberge
added a commit
that referenced
this pull request
Nov 22, 2014
use 24h format for releaseDirname instead of 12h
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
that is what was used previously, when 'moment' was used for date
formatting. 12h format causes terrible consequences:
(1) every timestamp repeats twice a day, for AM and PM. Which is bad
because deploy:cleanup task makes sorted list of directories, and
removes oldest, which might actually happen to be the directory which
was just released.
(2) if your project haven't specified exact version of grunt-shipit in
package.json, and multiple people are deploying from different
workspaces, one might be using 0.4.2 (12h) the other 0.4.0 (24h) and
then the cleanup of your current dir will hit you for sure.