This repository was archived by the owner on Mar 18, 2018. It is now read-only.
Custom directories separator #36
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hmm, I think it's better to just make a custom module "custom-path.js" that have a method join and take the separator as option. Also can you rebase to have a single or two commits please? http://git-scm.com/book/en/v2/Git-Tools-Rewriting-History |
Member
|
@Jaconil however thank you for the PR :) |
Jaconil
force-pushed
the
customDirSeparator
branch
9 times, most recently
from
1a74a87 to
0af97a9
Compare
Jaconil
force-pushed
the
customDirSeparator
branch
from
0af97a9 to
ebcb90b
Compare
Contributor
Author
|
Hi, I made some changes creating a custom module "posix-path" which uses Node.js path module functions for posix platforms. Could you review it ? |
Contributor
Author
|
I closed it in favor of #38 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue for directories separator which are not correct when the remote server and the local machine have a different OS (/ for Linux and \ for Windows).
The optional new option "dirSeparator" is created (default to "/").