Skip to content
This repository was archived by the owner on Mar 18, 2018. It is now read-only.

Conversation

@Jaconil
Copy link
Contributor

@Jaconil Jaconil commented Jan 19, 2015

Changes the publishing symlink to be relative instead of absolute. This update fixes publishing which doesn't work when the deployTo option is a relative path.

Relative links are better if the directories they target are moved or mounted elsewhere for example.

@gregberge
Copy link
Member

@Jaconil I see, but tests are not passing, and we don't need to expose relativeReleasePath

@Jaconil
Copy link
Contributor Author

Jaconil commented Jan 19, 2015

@neoziro I made some changes following your comment ;)

@gregberge
Copy link
Member

@Jaconil good thanks

gregberge added a commit that referenced this pull request Jan 19, 2015
Publishing with a relative symlink
@gregberge gregberge merged commit b0099d5 into shipitjs:master Jan 19, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants