This repository was archived by the owner on Mar 18, 2018. It is now read-only.
Don't pass exec's stderr to the callback. #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an error during rollback where the result of several exec's is expected to be [ 'path_to_file\n' ] but instead is returned as [ [ 'path_to_file\n', '' ] ].
Member
|
@hellosimon thanks for your fix, but can you add a test please? |
Contributor
Author
|
@neoziro ... no problem. Let me know if you spot any issues. Thanks! |
Member
|
Hmm, I am sorry but I think that it's important to return the stderr isn't it? |
Contributor
Author
|
Hmmm, not for the callback. If there is an error then "err" will get set in the callback and the right thing will happen. The callback function doesn't need to know what the error was just that one occurred. The connection pipes stderr to the linewrapper for the user to see what the error was. |
Member
|
Yes you are right, OK. |
gregberge
added a commit
that referenced
this pull request
May 9, 2014
Don't pass exec's stderr to the callback.
Member
|
@hellosimon you use grunt-shipit in production ? |
Contributor
Author
|
Not yet, but hopefully soon enough! :) I can say that it's working really well so far, so thanks for that! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an error during rollback where the result of several exec's is expected to be [ 'path_to_file\n' ]
but instead is returned as [ [ 'path_to_file\n', '' ] ].