Migrate plugin to the structure used since Shopware v5.2#4
Merged
mitelg merged 4 commits intoNov 14, 2017
Conversation
mitelg
requested changes
Nov 14, 2017
|
|
||
| namespace SwagMediaSftp; | ||
|
|
||
| require __DIR__ . "/vendor/autoload.php"; |
There was a problem hiding this comment.
needed for this lib "league/flysystem-sftp"
Contributor
There was a problem hiding this comment.
is not used here. should be in the subscriber file, shouldn't it?
There was a problem hiding this comment.
I think it make no real difference but It could be a better place there :-)
| <version>1.0.0</version> | ||
| <author>shopware AG</author> | ||
| <license>MIT</license> | ||
| <description>SFTP-Erweiterung für die Media Adapter</description> |
Contributor
There was a problem hiding this comment.
also translate the description
|
|
||
| class SwagMediaSftp extends Plugin | ||
| { | ||
| public function update(UpdateContext $context) |
Contributor
There was a problem hiding this comment.
the overwriting of these four methods is completely unnecessary, as they do exakt the same as the parent methods
Contributor
Author
There was a problem hiding this comment.
Indeed, I didn't check that. Removed the methods
mitelg
approved these changes
Nov 14, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation refers to this plugin and the other adapters from shopwareLabs already have been migrated.