#43276 Upgrades to use tags instead of tag_list #473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfboismenu
suggested changes
Jun 16, 2017
Contributor
jfboismenu
left a comment
jfboismenu
left a comment
There was a problem hiding this comment.
Seems like this is a breaking change, isn't it? Already downloaded bundles will lose their metadata.
| :return: metadata dictionary or None if not found | ||
| """ | ||
| cache_file = os.path.join(path, METADATA_FILE) | ||
| metadata_folder = self._get_metadata_folder(path) |
Contributor
There was a problem hiding this comment.
Won't this break backwards compatibility with currently cached bundles? It seems like we are. If that's indeed the case, a unit test proving it still works would be much appreciated. :)
Contributor
Author
There was a problem hiding this comment.
in order to minimize iterations i'll just revert to the previous behaviour.
jfboismenu
suggested changes
Jun 19, 2017
Contributor
jfboismenu
left a comment
jfboismenu
left a comment
There was a problem hiding this comment.
Isn't there a unit test to fix and if there is none, it would be nice if there was one.
Contributor
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tagsrather thantag_listin the app store.appstore-metadatafolder