Repository navigation
fix: small QA findings (task reads, favicon, initials, in-app dialogs) - #48
Merged
Merged
Conversation
GET /tasks, /tasks/my, /tasks/my/stats and /tasks/:id had no role rule, so a student got an empty list instead of a 403. Tasks are staff work, so these now require Admin, HOD or Faculty like the writes do.
The site had no icon, so browsers showed a blank tab icon and requested /favicon.ico, which 404'd. app/icon.svg is the sidebar's cap-on-blue mark.
Initials took the first word, so Dr. Priya Sharma showed DS. Honorifics such as Dr., Prof., Mr. and Ms. are skipped now (PS); a name that is only a title still gets initials.
Exams, assignments, files and timetable asked with window.confirm and reported errors with alert. They now use the shared Dialog: deletes, removing a paper and publishing results ask there, a failure shows its reason in the dialog, and other errors and the publish outcome show on the page. The assignment Delete button only appeared once the assignment had submissions, so an empty one could not be deleted; it now shows for the staff who can delete.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
These fix the smaller findings from the QA pass in #47.
GET /tasks,/tasks/my,/tasks/my/statsand/tasks/:idhad no role rule, so a student got an empty list. They now need Admin, HOD or Faculty, the same as the task writes. No student page calls them./favicon.icoreturned 404.app/icon.svgis the sidebar's mark: a cap on a blue square.window.confirmandalert. They now use the sharedDialog, the same pattern as deactivating an account:Rules used
Validation
pnpm test: 380 pass. A new test checks that the four task reads require ADMIN, HOD or FACULTY.pnpm lint,pnpm typecheck, api and dbbuild,next build,git diff --check: pass./icon.svg, it serves with 200, and there's no favicon 404.