Skip to content

#5666 Added in extra check if the image is already a png. #6014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

#5666 Added in extra check if the image is already a png. #6014

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Added in extra check if the image is already a png. 
(cherry picked from commit 177c23a73379bd08a40a7e0340285495d0404dce)
  • Loading branch information
@MarlowBrown
MarlowBrown committed Mar 28, 2025
commit a43ee4d213a83ec4b032a94f01df50db4677c734
2 changes: 1 addition & 1 deletion SignalServiceKit/Attachments/SignalAttachment.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -928,7 +928,7 @@ public class SignalAttachment: NSObject {
// transparent pixels (all screenshots fall into this bucket)
// and there is not a simple, performant way, to check if there
// are any transparent pixels in an image.
if dataSource.hasStickerLikeProperties {
if dataSource.hasStickerLikeProperties || attachment.fileExtension == "png" {
dataFileExtension = "png"
dataType = .png
} else {
Expand Down