[Core] switch_rtp.c: less OPENSSL_VERSION_NUMBER usage for readability. #728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@andywolk Please help to review this PR, thank you. |
|
Scan-build found bugs: https://public-artifacts.signalwire.com/drone/signalwire/freeswitch/46/index.html |
sunlin7
force-pushed
the
less-ssl-macro-condition
branch
from
c5823b2 to
d46c585
Compare
|
Scan-build found bugs: https://public-artifacts.signalwire.com/drone/signalwire/freeswitch/47/index.html |
sunlin7
force-pushed
the
less-ssl-macro-condition
branch
from
d46c585 to
00541b9
Compare
Contributor
Author
|
@andywolk not pushing, just want to know is there any update for this ticket? thank you. |
Contributor
Author
|
@andywolk The new version released days ago, shall we merge this merge request then it will get wide testing before next release? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
In
switch_rtp.c, there are many#ifdefconditions depends onOPENSSL_VERSION_NUMBER, which split code into many small chunk.This PR try to reduce the pre-processor conditions and increace readability.