Skip to content

Conversation

@ovadbar
Copy link
Contributor

@ovadbar ovadbar commented Oct 18, 2020

Currently mod_http_cache does not work for Google cloud. This adds support for it.

@signalwire-ci
Copy link

signalwire-ci bot commented Oct 18, 2020

@signalwire-ci
Copy link

signalwire-ci bot commented Oct 18, 2020

@signalwire-ci
Copy link

signalwire-ci bot commented Oct 18, 2020

@crienzo
Copy link
Member

crienzo commented Dec 16, 2020

We'll need some integration tests to accept this new feature. There's a lot of dynamic memory allocations and string manipulation that needs to be run through valgrind/ASAN during CI.

@crienzo
Copy link
Member

crienzo commented Feb 13, 2021

Reviewed latest changes. Still missing tests to accept this.

@ovadbar
Copy link
Contributor Author

ovadbar commented Feb 14, 2021

Reviewed latest changes. Still missing tests to accept this.

Yeah haven't had much time to work on this yet. I'll try and get some tests in the coming weeks.

@ovadbar
Copy link
Contributor Author

ovadbar commented Mar 10, 2021

Reviewed latest changes. Still missing tests to accept this.

Yeah haven't had much time to work on this yet. I'll try and get some tests in the coming weeks.

I added some tests looking for a review

@signalwire-ci
Copy link

signalwire-ci bot commented Mar 15, 2021

@signalwire-ci
Copy link

signalwire-ci bot commented Mar 15, 2021

@crienzo
Copy link
Member

crienzo commented Mar 15, 2021

making all mod_http_cache
make[4]: Entering directory '/drone/src/src/mod/applications/mod_http_cache'
  CC       mod_http_cache.lo
  CC       common.lo
mod_http_cache.c: In function 'do_config':
mod_http_cache.c:1706:6: error: 'else' without a previous 'if'
      else {
      ^~~~
Makefile:962: recipe for target 'mod_http_cache.lo' failed
make[4]: *** [mod_http_cache.lo] Error 1

@signalwire-ci
Copy link

signalwire-ci bot commented Mar 16, 2021

@andywolk
Copy link
Contributor

@ovadbar Unit tests failed. There is an overflow. Let me know if you don't have access to the report.

@signalwire-ci
Copy link

signalwire-ci bot commented Mar 17, 2021

@signalwire-ci
Copy link

signalwire-ci bot commented Mar 21, 2021

@signalwire-ci
Copy link

signalwire-ci bot commented Apr 29, 2021

@signalwire-ci
Copy link

signalwire-ci bot commented Aug 4, 2021

@signalwire-ci
Copy link

signalwire-ci bot commented Aug 6, 2021

@signalwire-ci
Copy link

signalwire-ci bot commented Aug 6, 2021

@signalwire-ci
Copy link

signalwire-ci bot commented Aug 9, 2021

@signalwire-ci
Copy link

signalwire-ci bot commented Aug 17, 2021

@signalwire-ci
Copy link

signalwire-ci bot commented Dec 5, 2021

@signalwire-ci
Copy link

signalwire-ci bot commented Dec 5, 2021

@signalwire-ci
Copy link

signalwire-ci bot commented Jun 5, 2022

@signalwire-ci
Copy link

signalwire-ci bot commented Jun 6, 2022

@signalwire-ci
Copy link

signalwire-ci bot commented Jun 23, 2022

@signalwire-ci
Copy link

signalwire-ci bot commented Jun 23, 2022

@signalwire-ci
Copy link

signalwire-ci bot commented Dec 26, 2022

@signalwire-ci
Copy link

signalwire-ci bot commented Dec 26, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants