-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Chages to include gcs in mod_http_cache #917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Scan-build found bugs: https://public-artifacts.signalwire.com/drone/signalwire/freeswitch/238/index.html |
|
Scan-build found bugs: https://public-artifacts.signalwire.com/drone/signalwire/freeswitch/239/index.html |
|
Scan-build found bugs: https://public-artifacts.signalwire.com/drone/signalwire/freeswitch/241/index.html |
|
We'll need some integration tests to accept this new feature. There's a lot of dynamic memory allocations and string manipulation that needs to be run through valgrind/ASAN during CI. |
|
Reviewed latest changes. Still missing tests to accept this. |
Yeah haven't had much time to work on this yet. I'll try and get some tests in the coming weeks. |
I added some tests looking for a review |
|
Unit-tests compilation failed: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/470/unit-tests-build-result.txt |
|
Scan-build compilation failed: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/470/scan-build-result.txt |
|
|
@ovadbar Unit tests failed. There is an overflow. Let me know if you don't have access to the report. |
|
Scan-build found bugs: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/47/index.html |
|
Unit-tests compilation failed: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/333/unit-tests-build-result.txt |
|
Scan-build compilation failed: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/333/scan-build-result.txt |
|
Scan-build found bugs: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/530/index.html |
|
Scan-build found bugs: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/896/index.html |
Currently mod_http_cache does not work for Google cloud. This adds support for it.