Skip to content

Conversation

@james-work-account
Copy link
Contributor

On iOS, you can open a card but can't close it again. The exception to this is if you open another card - this closes the first card and opens the second, but then there's no way to close the second (without opening a third, etc).

Changing the on:pointerup and on:keyup listeners to on:click seems to resolve this (aka make it a standard button click listener). I don't know if there was a reason why these other listeners were chosen, hence making this a Draft PR for now, but if this change is okay then I'll open it up.

@netlify
Copy link

netlify bot commented Nov 1, 2022

Deploy Preview for deck-24abcd ready!

Name Link
🔨 Latest commit 960268f
🔍 Latest deploy log https://app.netlify.com/sites/deck-24abcd/deploys/63611f792cc24f000835fd6a
😎 Deploy Preview https://deploy-preview-13--deck-24abcd.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@simeydotme
Copy link
Owner

yeah @james-work-account the reason I chose to use pointerup & blur and not a simple click-event is because when I was trying to interact (without gyro) by touchmove on a card, it was registering a click and deselecting the card on every interaction. At least in my emulator and on my S10. I built it without Gyro originally and all the effects were triggered with finger-swipes.

Thanks for raising this and let me check it out on a few devices :)
(I did see it in your previous PR but I left it as I didn't think it was that big of an Issue as the blur event should handle it. But now I can see it is, hah.)

I think the issue I had may be gone after I changed from touchmove to pointermove

@simeydotme simeydotme assigned simeydotme and unassigned simeydotme Nov 1, 2022
@simeydotme simeydotme added the ✨ enhancement New feature or request label Nov 1, 2022
@simeydotme simeydotme marked this pull request as ready for review November 1, 2022 14:59
@simeydotme
Copy link
Owner

ah, ok I just tested on an iPhone... seems the iPhone not respecting the blur event, that's why you can't click off it. Probably something I caused somewhere else in the CSS. But I think this PR is good for now 👍

@simeydotme simeydotme merged commit 379711e into simeydotme:main Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants