Update cards to be buttons to allow for keyboard navigation #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for deck-24abcd ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Owner
|
dude that's a pretty nice addition :) I am about to make some changes on another branch and will try to incorporate this |
Owner
|
Took your suggestion in the revamp branch |
Contributor
Author
|
Glad I could help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to everything in the cards being divs, being able to open the cards using basic keyboard navigation isn't possible. This pull request changes interactive components into buttons, adds aria-labels to each button so screen readers will read out which card they are over, and changes the event listener to be on click so it can be triggered with a keyboard "enter" press. It also (hopefully) removes the default styling from the buttons so it doesn't look any different.
To manually check this, firstly you should be able to click/mouseover like before. Secondly, you should be able to "tab" between each card and press "enter" to open/close them.
Note that I really don't know what I'm doing with Svelte, so if I've introduced any anti-patterns then I'm happy to change them. Also, I haven't checked this change in all browsers but it seems to work at least in Chrome and Firefox on macOS.