Skip to content

Improve tempfile management #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
krasnoukhov merged 1 commit into from
Jun 13, 2023
Merged

Improve tempfile management #2

krasnoukhov merged 1 commit into from
Jun 13, 2023

Conversation

@krasnoukhov
Copy link
Member

@krasnoukhov krasnoukhov commented Jun 13, 2023

This addresses two things:

  • File contents is guaranteed to be flushed on disk (because of close) so we should not see that bugsnag error any more
  • Tempfile is removed immediately after a block, instead of waiting for the GC to run

@krasnoukhov krasnoukhov requested review from E70M, berowar and hansenjl June 13, 2023 07:40
@krasnoukhov krasnoukhov merged commit 6615f7e into master Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berowar berowar berowar approved these changes

@E70M E70M Awaiting requested review from E70M

@hansenjl hansenjl Awaiting requested review from hansenjl

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@krasnoukhov @berowar