Remove handler of distinct keyboard shortcut #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maschina
changed the title
Owner
|
Duplicate of #194 |
Contributor
Author
|
How about marking keyUp/keyDown related functions as deprecated? What do you think? |
sindresorhus
reviewed
May 6, 2025
Owner
|
Alright. I will accept this. But I don't plan any more changes to the old keyboard handling. I don't want to maintain code I don't use and that will be removed in a few years. |
Contributor
Author
|
OK, makes sense. |
Owner
Yeah, I plan to doc deprecate it later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new function to remove the handler of a distinct keyboard shortcut. It extends to public function
removeAllHandlers()for a more fine-granular control.My app needs to unload a certain number of models that contain registered shortcuts. Once the module is unloaded, the shortcut should be unregistered. The
removeAllHandlersdoes not give me the control to unregister only certain shortcuts.