Skip to content

Conversation

@futpib
Copy link
Contributor

@futpib futpib commented Mar 16, 2019

Fixes #83

This adds support for async iteration by adding globby.stream which returns a ReadableStream.

Node 10 introduced experimental async iterator support to ReadableStream so if supported by one's node version, one can use globby.stream in a for-await-of loop as witnessed by this test https://github.com/futpib/globby/blob/958e81505b1baa7d73e29dbe3468123032cce9cf/test.js#L85-L92

@futpib futpib force-pushed the async-iteration branch from 958e815 to 6b8c1ff Compare April 6, 2019 10:29
@sindresorhus
Copy link
Owner

@sindresorhus
Copy link
Owner

Can you fix the merge conflicts?

@futpib futpib force-pushed the async-iteration branch from 6b8c1ff to d740c76 Compare June 14, 2019 20:34
@futpib futpib force-pushed the async-iteration branch from e211cdd to 69940a0 Compare June 14, 2019 20:59
@futpib
Copy link
Contributor Author

futpib commented Jun 14, 2019

I have addressed all the review comments 👌

@sindresorhus sindresorhus merged commit 8aadde8 into sindresorhus:master Jun 15, 2019
@sindresorhus
Copy link
Owner

Thanks 🙌

You need to submit the PR URL here to claim the bounty: https://issuehunt.io/r/sindresorhus/globby/issues/83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Async-iteration support

3 participants