Skip to content

pick-deep: Fix the case when the key or element is an union type (#1224) #1241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
taiyakihitotsu wants to merge 9 commits into
base: main
Choose a base branch
from
Open

pick-deep: Fix the case when the key or element is an union type (#1224) #1241

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1a82441
pick-deep: Fix the case when the key or element is an union type (#1224)
taiyakihitotsu Sep 24, 2025
5303a23
Update pick-deep.ts
sindresorhus Sep 27, 2025
d821504
resolve conflict.
taiyakihitotsu Sep 27, 2025
a38415e
Fix #1223
taiyakihitotsu Sep 27, 2025
a8ac395
Fix: union type including same shape pbjects
taiyakihitotsu Sep 28, 2025
809e363
Fix: internal LastOfUnion
taiyakihitotsu Oct 1, 2025
dce5b64
refactor: LastOfUnion moved to internal
taiyakihitotsu Oct 10, 2025
82e8590
refactor: Using IsNever instead of IsEqual<T, never>
taiyakihitotsu Oct 10, 2025
cab8667
Update pick-deep.d.ts
sindresorhus Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: Using IsNever instead of IsEqual<T, never>
  • Loading branch information
@taiyakihitotsu
taiyakihitotsu committed Oct 10, 2025
commit 82e8590552d94d0f6d2ef8a147bc35398c02614e
4 changes: 2 additions & 2 deletions source/pick-deep.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,9 +333,9 @@ type _MergeTreeObject<A extends object, B extends object, KU extends (keyof A |
: never;

type MergeTreeObject<A extends object, B extends object> =
Or<IsEqual<A, never>, IsEqual<A, {}>> extends true
Or<IsNever<A>, IsEqual<A, {}>> extends true
? B
: Or<IsEqual<B, never>, IsEqual<B, {}>> extends true
: Or<IsNever<B>, IsEqual<B, {}>> extends true
? A
: _MergeTreeObject<A, B, As<(KeysOfUnion<A> | KeysOfUnion<B>), (keyof A | keyof B)>>;

Expand Down