-
-
Notifications
You must be signed in to change notification settings - Fork 660
Add FunctionOverloads type
#1264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andreww2012
wants to merge
11
commits into
sindresorhus:main
Choose a base branch
from
andreww2012:feat/function-overloads
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
61ef2cc
feat: add `FunctionOverloads` type
andreww2012 06373ed
Update function-overloads.d.ts
sindresorhus 3c4541c
Update function-overloads.ts
sindresorhus c3400fe
feat: add edge any/never/unknown tests
andreww2012 04871db
docs: mention use cases and known limitations
andreww2012 19ea1d7
docs: mention TS issue about type interface for overloaded functions
andreww2012 f140e62
docs: remove limitation of losing `readonly` modifier
andreww2012 f91847c
chore: ensure Function category types go in alphabetical order
andreww2012 33e5b51
chore: use existing types for certain expressions
andreww2012 24ee5fe
chore: add examples to `FunctionWithMaybeThisParameter` utility usage
andreww2012 02f0a07
refactor: simply `SetReturnType` and `SetParameterType` types
andreww2012 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
feat: add
FunctionOverloads type
- Loading branch information
commit 61ef2cc502d47c66ee45b67f8daf314ab548f263
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| import type {FunctionWithMaybeThisParameter} from './internal/function.d.ts'; | ||
| import type {IsEqual} from './is-equal.d.ts'; | ||
|
|
||
| /** | ||
| Create a union of all the function's overloads. | ||
andreww2012 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| @example | ||
| ```ts | ||
| import type {FunctionOverloads} from 'type-fest'; | ||
| function request(url: string): Promise<string>; | ||
| function request(url: string, options: {json: true}): Promise<unknown>; | ||
| function request(url: string, options?: {json?: boolean}) { | ||
| // ... | ||
| } | ||
| type RequestFunctionType = FunctionOverloads<typeof request>; | ||
| //=> ((url: string) => Promise<string>) | ((url: string, options: {json: true}) => Promise<unknown>) | ||
| ``` | ||
| This type can be used to extract event types of a Vue component: | ||
| @example | ||
| ```ts | ||
| // Given a component `HelloWorld` defines its events as follows: | ||
| defineEmits<{ | ||
| submit: [formData: FormData]; | ||
| cancel: []; | ||
| }>(); | ||
| // Extract the type of `submit` event like this: | ||
| import type {ArrayTail, FunctionOverloads} from 'type-fest'; | ||
| import HelloWorld from './HelloWorld.vue'; | ||
| type SubmitEventType = ArrayTail<Parameters<Extract<FunctionOverloads<InstanceType<typeof HelloWorld>['$emit']>, (event: 'submit', ...args: any[]) => void>>>; | ||
| //=> [formData: FormData] | ||
| ``` | ||
andreww2012 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| @category Function | ||
| */ | ||
| export type FunctionOverloads<T> = FunctionOverloadsInternal<T>; | ||
|
|
||
| type FunctionOverloadsInternal< | ||
| AllOverloads, | ||
| CheckedOverloads = {}, | ||
| MustStopIfParametersAreEqual extends boolean = true, | ||
| LastParameters = never, | ||
| > = AllOverloads extends ( | ||
| this: infer ThisType, | ||
| ...args: infer ParametersType extends readonly unknown[] | ||
| ) => infer ReturnType | ||
| ? // This simultaneously checks if the last and the current parameters are equal and `MustStopIfParametersAreEqual` flag is true | ||
| IsEqual< | ||
| [LastParameters, true], | ||
| [ | ||
| ParametersType, | ||
| [MustStopIfParametersAreEqual] extends [true] ? true : false, // Prevents distributivity | ||
| ] | ||
| > extends true | ||
| ? never | ||
| : | ||
| | FunctionOverloadsInternal< | ||
| // Normally, in `(FunctionType extends (...args: infer P) => infer R)`, compiler infers | ||
| // `P` and `R` from the last function overload. | ||
| // This trick (intersecting one of the function signatures with the full signature) | ||
| // makes compiler infer a last overload that do not equal one of the concatenated ones. | ||
| // Thus, we're ending up iterating over all the overloads from bottom to top. | ||
| // Credits: https://github.com/microsoft/TypeScript/issues/14107#issuecomment-1146738780 | ||
| CheckedOverloads & AllOverloads, | ||
| CheckedOverloads & ((this: ThisType, ...args: ParametersType) => ReturnType), | ||
| MustStopIfParametersAreEqual extends true ? false : true, | ||
| ParametersType | ||
| > | ||
| | FunctionWithMaybeThisParameter<ThisType, ParametersType, ReturnType> | ||
| : never; | ||
|
|
||
| export {}; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| import type {IsUnknown} from '../is-unknown.d.ts'; | ||
|
|
||
| /** | ||
| Constructs a function type with an optional `this` parameter. | ||
andreww2012 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| If `this` parameter is not needed, pass `unknown`. | ||
| */ | ||
| export type FunctionWithMaybeThisParameter< | ||
| ThisParameter, | ||
| Parameters_ extends readonly unknown[], | ||
| TypeToReturn, | ||
| > = | ||
| // If a function does not specify the `this` parameter, it will be inferred to `unknown` | ||
| IsUnknown<ThisParameter> extends true | ||
| ? (...args: Parameters_) => TypeToReturn | ||
| : (this: ThisParameter, ...args: Parameters_) => TypeToReturn; | ||
|
|
||
| export {}; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,100 @@ | ||
| import {expectType} from 'tsd'; | ||
| import type {FunctionOverloads} from '../source/function-overloads.d.ts'; | ||
|
|
||
| type Function1 = (foo: string, bar: number) => object; | ||
| type Function2 = (foo: bigint, ...bar: any[]) => void; | ||
|
|
||
| declare const normalFunction: FunctionOverloads<Function1>; | ||
| expectType<Function1>(normalFunction); | ||
|
|
||
| // Note: function overload is equivalent to intersecting its signatures | ||
|
|
||
| declare const twoOverloads: FunctionOverloads<Function1 & Function2>; | ||
| expectType<Function1 | Function2>(twoOverloads); | ||
|
|
||
| declare const twoIdenticalOverloads: FunctionOverloads<Function1>; | ||
| expectType<Function1>(twoIdenticalOverloads); | ||
|
|
||
| type Function3 = (foo: string, bar: number, baz?: boolean) => object; | ||
|
|
||
| declare const twoOverloadWithAssignableSignature: FunctionOverloads<Function1 & Function3>; | ||
| expectType<Function1 | Function3>(twoOverloadWithAssignableSignature); | ||
|
|
||
| declare const threeOverloads: FunctionOverloads<Function1 & Function2 & Function3>; | ||
| expectType<Function1 | Function2 | Function3>(threeOverloads); | ||
|
|
||
| type Function4 = (...foo: any[]) => void; | ||
| type Function5 = (...foo: readonly any[]) => void; | ||
|
|
||
| declare const normalFunctionWithOnlyRestWritableParameter: FunctionOverloads<Function4>; | ||
| expectType<Function4>(normalFunctionWithOnlyRestWritableParameter); | ||
|
|
||
| declare const normalFunctionWithOnlyRestReadonlyParameter: FunctionOverloads<Function5>; | ||
| expectType<Function5>(normalFunctionWithOnlyRestReadonlyParameter); | ||
|
|
||
| declare const twoOverloadsWithDifferentRestParameterReadonliness: FunctionOverloads< | ||
| Function4 & Function5 | ||
| >; | ||
| // Expected: it seems like the compiler ignores subsequent identical up to `readonly` modifier overloads | ||
| expectType<Function4>(twoOverloadsWithDifferentRestParameterReadonliness); | ||
|
|
||
| declare const twoOverloadsWithDifferentRestParameterReadonlinessReversed: FunctionOverloads< | ||
| Function5 & Function4 | ||
| >; | ||
| // Expected: it seems like the compiler ignores subsequent identical up to `readonly` modifier overloads | ||
| expectType<Function5>(twoOverloadsWithDifferentRestParameterReadonlinessReversed); | ||
|
|
||
| type Function6 = (foo: string, ...bar: any[]) => void; | ||
| type Function7 = (foo: string, ...bar: readonly any[]) => void; | ||
|
|
||
| declare const normalFunctionWithNormalAndRestWritableParameter: FunctionOverloads<Function6>; | ||
| expectType<Function6>(normalFunctionWithNormalAndRestWritableParameter); | ||
|
|
||
| declare const normalFunctionWithNormalAndRestReadonlyParameter: FunctionOverloads<Function7>; | ||
| // Expected: readonly rest parameter cannot be represented with tuples | ||
| expectType<(foo: string, ...bar: any[]) => void>(normalFunctionWithNormalAndRestReadonlyParameter); | ||
|
|
||
| type Function8 = () => never; | ||
|
|
||
| declare const normalFunctionNoParameters: FunctionOverloads<Function8>; | ||
| expectType<Function8>(normalFunctionNoParameters); | ||
|
|
||
| declare const twoOverloadsWithNoAndPresentParameters: FunctionOverloads<Function8 & Function6>; | ||
| expectType<Function8 | Function6>(twoOverloadsWithNoAndPresentParameters); | ||
|
|
||
| type Function9 = (event: 'event9', arg: string) => void; | ||
| type Function10 = (event: 'event10', arg: number) => string; | ||
| type Function11 = (event: 'event11', arg: boolean) => never; | ||
| type Function12 = (event: 'event12', arg: bigint) => object; | ||
|
|
||
| declare const manyOverloads: FunctionOverloads< | ||
| Function1 & | ||
| Function2 & | ||
| Function3 & | ||
| Function4 & | ||
| Function5 & | ||
| Function6 & | ||
| Function7 & | ||
| Function8 & | ||
| Function9 & | ||
| Function10 & | ||
| Function11 & | ||
| Function12 | ||
| >; | ||
| expectType< | ||
| | Function1 | ||
| | Function2 | ||
| | Function3 | ||
| | Function4 | ||
| | Function5 | ||
| | Function6 | ||
| | Function7 | ||
| | Function8 | ||
| | Function9 | ||
| | Function10 | ||
| | Function11 | ||
| | Function12 | ||
| >(manyOverloads); | ||
|
|
||
| declare const noOveloads: FunctionOverloads<{}>; | ||
| expectType<never>(noOveloads); | ||
andreww2012 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.