clarified user binding (hopefully) #48
Conversation
|
ready for review? |
|
I think I actually pushed it a bit early. Can I get back with you tomorrow
AM?
…On Jan 5, 2017 10:03 PM, "Vanessa Sochat" ***@***.***> wrote:
ready for review?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#48 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHUUXA2S2eaEkI7qmLIVTq11HhflRUHaks5rPa8AgaJpZM4LcUTX>
.
|
|
you bet! That's why I checked :) That's actually really good, because I looked into why travis wasn't building, and for some reason it was just triggering from your circle account! It must have disabled the main one or something strange... anyway I re-enabled it, so your update tomorrow morning will be a good test if the travis is working again to preview changes. |
|
Weird. Hope it works now.
…On Jan 5, 2017 10:08 PM, "Vanessa Sochat" ***@***.***> wrote:
you bet! That's why I checked :) That's actually really good, because I
looked into why travis wasn't building, and for some reason it was just
triggering from your circle account! It must have disabled the main one or
something strange... anyway I re-enabled it, so your update tomorrow
morning will be a good test if the travis is working again to preview
changes.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#48 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHUUXLKzHdt4csSUNZfyUePevjWL53wgks5rPbAzgaJpZM4LcUTX>
.
|
|
actually it was building on circle - the travis was disabled because there isn't an easy/free artifacts option. I'm going to look into why it's not building on circle, and hopefully you have one more push haha. |
|
I don't currently have a circle account. Do I need to get one? Anyway,
I'd better walk the dog and go to bed. I can push again in the morning if
you need another test. :-)
…On Thu, Jan 5, 2017 at 10:32 PM, Vanessa Sochat ***@***.***> wrote:
actually it was building on circle - the travis was disabled because there
isn't an easy/free artifacts option. I'm going to look into why it's not
building on circle, and hopefully you have one more push haha.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#48 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHUUXOeWMTE5bVic54YZNiyAjvrbe_qXks5rPbXQgaJpZM4LcUTX>
.
|
|
No you shouldn't need to! It should build all PRs, even if you don't have an account (because it's hooked up via my account). I just reset the build, and enabled PRs, so it may be the case that this one doesn't work, in which case we can try again next time. It's not a huge deal, because I can pull and preview locally, but it will be nice to have. |
|
I think this should be ready for review now. I'm happy to make dummy
pushes on this or another PR too if you need more testing for CircleCI.
…On Thu, Jan 5, 2017 at 10:39 PM, Vanessa Sochat ***@***.***> wrote:
No you shouldn't need to! It should build all PRs, even if you don't have
an account (because it's hooked up via my account). I just reset the build,
and enabled PRs, so it may be the case that this one doesn't work, in which
case we can try again next time. It's not a huge deal, because I can pull
and preview locally, but it will be nice to have.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#48 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHUUXEXJm811X1xcfA7PHKcyV11T1c8tks5rPbeIgaJpZM4LcUTX>
.
|
|
Just previewed locally - looks good! I think this will be very helpful. Thanks again for making this more clear for the admin/user! |
2 participants
Hopefully these comments will save some admin a little time.