Skip to content

Conversation

@kklurz
Copy link
Member

@kklurz kklurz commented Feb 28, 2023

  • This PR adds an MLP modulator as used in Toliaslab. The version from Toliaslab is changed to a) have a similar structure as the shifter module from neuralpredictors and b) to allow the modulator to be used by models with more than one output (like Zero Inflated Distributions as opposed to Poisson)
  • The PR also changes the NeuroNormalizer to have the option to center the behavior variables around zero, i.e. to subtract the mean before variance normalizing. While this does not make sense from a physical perspective (pupil dilation for instance can not be negative and should not be centered around zero), it is necessary for the modulator network: Passing in "0" should result in no modulation.

@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.09 ⚠️

Comparison is base (4a32cbf) 8.44% compared to head (35dba16) 8.35%.

❗ Current head 35dba16 differs from pull request most recent head a64fb3d. Consider uploading reports for the commit a64fb3d to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##            main    #190      +/-   ##
========================================
- Coverage   8.44%   8.35%   -0.09%     
========================================
  Files         50      51       +1     
  Lines       5009    5060      +51     
  Branches     833     840       +7     
========================================
  Hits         423     423              
- Misses      4557    4608      +51     
  Partials      29      29              
Impacted Files Coverage Δ
neuralpredictors/data/transforms.py 0.00% <0.00%> (ø)
neuralpredictors/layers/modulators/mlp.py 0.00% <0.00%> (ø)
neuralpredictors/layers/shifters/mlp.py 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@mohammadbashiri mohammadbashiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Thanks!

@mohammadbashiri mohammadbashiri merged commit 34958aa into sinzlab:main Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants