Decoding base64 encoded request body#3
Closed
AlexLast wants to merge 4 commits into
Closed
Conversation
AlexLast
commented
Sep 29, 2017
AlexLast
commented
- When using binary media types in API gateway, request bodies are base64 encoded. This allows the body to be decoded.
sivel
requested changes
Sep 29, 2017
|
|
||
| class FlaskLambda(Flask): | ||
| def __call__(self, event, context): | ||
| if 'isBase64Encoded' in event and event['isBase64Encoded']: |
Owner
There was a problem hiding this comment.
Don’t check if a key is in the duct and then fetch it. Use .get instead.
Author
There was a problem hiding this comment.
For some reason I thought .get was deprecated, will update..
sivel
reviewed
Nov 6, 2017
| class FlaskLambda(Flask): | ||
| def __call__(self, event, context): | ||
| if event.get('isBase64Encoded', False): | ||
| event['body'] = base64.b64decode(event['body']) |
Owner
There was a problem hiding this comment.
These lines should prob ably go after the if 'httpMethod'... block, so that we are only doing this when in lambda, and not doing it before we make that determination.
Author
There was a problem hiding this comment.
@sivel Fair comment, I've moved this under the httpMethod condition block so it will only be caught if we're in Lambda.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.