[relro] Detect BIND_NOW via DT_FLAGS_1 (DF_1_NOW) and use bitmask for DF_BIND_NOW - #315
Merged
Merged
Conversation
…k for DF_BIND_NOW Add support for detecting RELRO/BIND_NOW through DT_FLAGS_1 (DF_1_NOW), in addition to DT_BIND_NOW and DT_FLAGS. Also switch DF_BIND_NOW check from equality (8) to a proper bitmask, and rename variables to Go-style camelCase for clarity.
Owner
|
This has conflicts due to the recent merge of another bug around BIND_NOW, Can you please rebase this? |
Contributor
Author
Done. Rebased and resolved the conflicts. |
Contributor
Author
|
Kindly ping @slimm609 for review this PR. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for detecting RELRO/BIND_NOW through DT_FLAGS_1 (DF_1_NOW), in addition to DT_BIND_NOW and DT_FLAGS. Also switch DF_BIND_NOW check from equality (8) to a proper bitmask, and rename variables to Go-style camelCase for clarity.