Skip to content

Testing Router Methods #1882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2016
Merged

Testing Router Methods #1882

merged 1 commit into from
May 19, 2016

Conversation

@danielgsims
Copy link

@danielgsims danielgsims commented May 17, 2016

  • Testing sad path from route lookup
  • Testing that urlFor proxies pathFor but triggers warning

Testing Router Methods
2900788 
  * Testing sad path from route lookup
  * Testing that urlFor proxies pathFor but triggers warning
@danielgsims danielgsims mentioned this pull request May 17, 2016
Closed
@coveralls
Copy link

coveralls commented May 17, 2016

Coverage Status

Coverage increased (+0.2%) to 93.789% when pulling 2900788 on danielgsims:router-test-alt into 794073a on slimphp:3.x.

@danielgsims
Copy link
Author

danielgsims commented May 17, 2016

@dopesong - Writing the error handler this way helped us get around the weird error-conversion issue with the HVVM build on travis too

@dopesong
Copy link
Contributor

dopesong commented May 17, 2016

Glad to see that ;)

@akrabat akrabat added this to the 3.5.0 milestone May 19, 2016
@akrabat akrabat merged commit 2900788 into slimphp:3.x May 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.5.0

Development

Successfully merging this pull request may close these issues.

4 participants

@danielgsims @coveralls @dopesong @akrabat