Container converts not UnexpectedValueException but InvalidArgumentException #1883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopesong
force-pushed
the
container-test-wrong-exception
branch
from
06f8551 to
b9d08e9
Compare
dopesong
force-pushed
the
container-test-wrong-exception
branch
from
b9d08e9 to
367677f
Compare
|
You shouldn't need the annotation and calling set expected exception. |
|
I know. Trying to understand what is wrong with HHVM. |
dopesong
force-pushed
the
container-test-wrong-exception
branch
2 times, most recently
from
b896c73 to
731715c
Compare
dopesong
force-pushed
the
container-test-wrong-exception
branch
from
731715c to
5a98d09
Compare
…ception, test correct exception
dopesong
force-pushed
the
container-test-wrong-exception
branch
from
5a98d09 to
4de1902
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests correct exception