Check if getReasonPhrase returns empty message #1884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/Http/ResponseTest.php
Outdated
| $responseStatus->setValue($response, '404'); | ||
|
|
||
| $this->assertEquals('Not Found', $response->getReasonPhrase()); | ||
| $this->assertEquals('', $responseWithNoMessage->getReasonPhrase()); |
There was a problem hiding this comment.
Please add this one as it's own test method.
Also, why does the 404 test use Reflection to set the Status?!
dopesong
force-pushed
the
response-status-phrase-test
branch
from
1e26aef to
b7a2f57
Compare
akrabat
added a commit
that referenced
this pull request
May 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.