-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Small fixes #1889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Small fixes #1889
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
dfe2faa
refactor: DRY
llvdl 3475996
removed unused use statements
llvdl ca50316
fixed docblock, added typehint
llvdl 593280b
added a test for UploadFile
llvdl 1ac6460
added check for single method as string in Route constructor, updated…
llvdl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
added check for single method as string in Route constructor, updated…
… docblock
- Loading branch information
commit 1ac64601141105f25e91deab22000f43ea57b8a6
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why add support for
string?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because FastRoute supports both a string parameter and an array of string. Because there is no
arraytypehint on$methods,stringwas already supported. I updated the docblock to reflect this.Also, when setting
Route::$methodsin the constructor, the value is set to an array, soRoute::getMethods()always returns an array as stated in the docblock.